On Tue, Apr 30, 2013 at 06:49:03PM -0400, Chuck Lever wrote:
> Clean up.
I don't want to describe something as cleanup unless it's obvious it
won't change behavior. But:
> @@ -3033,7 +3032,7 @@ nfsd4_encode_readlink(struct nfsd4_compoundres *resp, __be32 nfserr, struct nfsd
> static __be32
> nfsd4_encode_readdir(struct nfsd4_compoundres *resp, __be32 nfserr, struct nfsd4_readdir *readdir)
> {
> - int maxcount;
> + unsigned int maxcount;
> loff_t offset;
> __be32 *page, *savep, *tailbase;
> __be32 *p;
This one, at least, is an actual behavior change. (Note we've got an
"if (maxcount < 0) ..." later on.) Maybe not a real problem, I haven't
checked.
And I haven't checked the others carefully.
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
