----- Original Message ----- > From: Simo Sorce <simo@xxxxxxxxxx> > > > krb5_cc_retrieve_cred is available in MIT too, I would try to avoid > using ifedfs here and come up with common code that works for both to > avoid bugs that may cause different behavior in parallel code paths > depending on which library is used. > > This looks like just gratuitous re-indentation, I would drop it it's not > needed and makes the patch bigger. I did it on purpose and said so in the patch description header, because I knew you are going to optimize it out anyway. I don't think that iterating through every credential was ever considered a proper way to implement check_for_taregt function. > > MIT doesn't have krb5_get_err_text at all so it shouldn't be tried out > at all if MIT is available. > > I think you should ratrher add a keberos.m4 macro to check for > krb5_get_err_text then change this to something like: If it's not available on mit-krb5 and is deprecated on Heimdal, why bother with krb5_get_err_text at all? -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
