Re: [PATCH] sunrpc: the cache_detail in cache_is_valid is unused any more

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2013-03-28 at 21:53 +0800, chaoting fan wrote:
> the cache_detail(*detail) in function cache_is_valid is unused any more,
> mark it to be unused to avoid make warning.
> 
> Signed-off-by: fanchaoting <fanchaoting@xxxxxxxxxxxxxx>
> 
> ---
>  net/sunrpc/cache.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
> index 9afa439..efea2d9 100644
> --- a/net/sunrpc/cache.c
> +++ b/net/sunrpc/cache.c
> @@ -201,7 +201,7 @@ static int cache_make_upcall(struct cache_detail
> *cd, struct cache_head *h)
>  	return cd->cache_upcall(cd, h);
>  }
> 
> -static inline int cache_is_valid(struct cache_detail *detail, struct
> cache_head *h)
> +static inline int cache_is_valid(struct cache_detail *unused, struct
> cache_head *h)
>  {
>  	if (!test_bit(CACHE_VALID, &h->flags))
>  		return -EAGAIN;
> -- 1.7.10.4

Why not just remove it altogether? There are only 3 callers.

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux