On Monday 25 March 2013 08:42:32 Steve Dickson wrote: > On 24/03/13 18:21, Mike Frysinger wrote: > > Newer autotools will use both CFLAGS and <target>_CFLAGS when compiling > > the <target>. Adding the build settings to the target-specific flags no > > longer works as a way to compile build-time tools. > > > > Instead, clobber the global flags. This triggers an automake warning, > > but the end result actually works (unlike the existing code). > > This patch is causing the following warnings: > ... > You didn't see these in your testing? in my summary: Instead, clobber the global flags. This triggers an automake warning, but the end result actually works (unlike the existing code). > Also what exactly broke that this patch fixes? also in my summary: Newer autotools will use both CFLAGS and <target>_CFLAGS when compiling the <target>. so when you cross-compile (e.g. --build=x86_64-linux-gnu --host=arm-linux- gnu), and you set CFLAGS to include settings which are valid only for the host (e.g. -mfloat-abi=hard -mfp=neon), those flags will also get passed to the build compiler when compiling these tools and they'll error out (because the build gcc doesn't recognize these flags). -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
