On Thu, 2013-03-21 at 13:25 +0200, Boaz Harrosh wrote: > On 03/20/2013 07:39 PM, Trond Myklebust wrote: > > In order to be able to safely return the layout in nfs4_proc_setattr, > > we need to block new uses of the layout, wait for all outstanding > > users of the layout to complete, commit the layout and then return it. > > > > This patch adds a helper in order to do all this safely. > > > > Hi Trond > > It looks like this patchset might actually fix my problem as well. > > I've been super swamped with internal work at Panasas, and never got > a chance to cleanup and review my experimental fixes. So it looks like > you bit me to it. Your work looks much better, and deeper then what I > had. Though one concern I have is that I need those for @stable so my > change was as minimal as possible, single patch. I chose to split it into 3 patches because these are really 3 different problems. The first patch (hopefully) fixes Benny's Oops. The second fixes a memory leak, while the last one fixes a potential data corruption. > I have just arrived back to Israel today, and will only have time to test > all this Next week. I have just the right setup for this. I understand that > for you it might be harder because Files-layout does not support segments and > my deadlock can only happen with two segments and up. > > [BTW: I did not even reviewed the code yet will do ASAP] Thanks! -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
