On 2013-03-18 19:04, Fred Isaman wrote: > On Mon, Mar 18, 2013 at 12:22 PM, Benny Halevy <bhalevy@xxxxxxxxxx> wrote: > >>> NACK. I see no evidence that we've addressed the issues that were raised >>> by Fred in commit 1825a0d08f22463e5a8f4b1636473efd057a3479 (NFS: prepare >>> coalesce testing for directio). >>> If you think that his concerns about the coalescing assumptions are no >>> longer true, then please point to why this is the case. AFAICR that >>> patch was added to fix corruption issues. >>> >> >> We see no problems with this patch with the workloads we're testing. >> Do you have a test that reproduces the original problem that we can try running? >> >> Benny > > A problem case is if the layout ends within the page request, which > can happen due to the misalignment. First, the file layout currently supports only whole file layouts so I don't see how that's a problem. Regardless, I'd rather trim the layout segment to PAGE_SIZE boundaries and get a new layout from the page aligned offset and on with minlength = PAGE_SIZE (as we do today). Benny > > Fred > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
