On Tue, 2013-03-19 at 10:09 -0400, J. Bruce Fields wrote: > On Tue, Mar 19, 2013 at 09:07:42AM -0400, Trond Myklebust wrote: > > Sometimes, we actually _want_ to do open-by-filehandle, for instance > > when recovering opens after a network partition, or when called > > from nfs4_file_open. > > Enable that functionality using a new capability NFS_CAP_ATOMIC_OPEN_V1, > > and which is only enabled for NFSv4.1 servers that support it. > > So you're assuming NFS4ERR_INVAL is how the server indicates lack of > support? Looking at the list of valid errors for OPEN in section 15.2 of RFC5661, I don't see what else fits the bill. > Looking back at NFS server history.... I think that's what it did before > supporting these types, but I wonder if that was really right. Possibly > it's just a bug not to support the new claim types in a 4.1 server. I've assumed that it isn't. NFSv4.1 is the very first minor version, so it's not supposed to contain any mandatory new features. Yes, I know we broke the rules on that one in spectacular fashion with sessions, but I'm assuming that is the only exception... -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html