On Wed, Mar 06, 2013 at 10:18:38AM +0400, Stanislav Kinsbursky wrote: > 06.03.2013 09:06, Stanislav Kinsbursky пишет: > >06.03.2013 01:20, J. Bruce Fields пишет: > >>On Thu, Feb 28, 2013 at 03:09:59PM +0300, Stanislav Kinsbursky wrote: > >>>Function nfsd4_client_tracking_init() can return error. > >> > >>Before, I think that we the nfsd4_client_* functions just became no-ops > >>in this case. With the result that no client records get written, and > >>so clients are unable to reclaim on the next boot. > >> > >>Which is annoying, but possibly not as annoying as your server > >>completely refusing to start. > >> > >>It's arguably more helpful in the long run to fail immediately when we > >>recognize reboot recovery isn't going to work. But in practice this may > >>mean people that never knew they had a problem suddenly have servers > >>that don't start at all. > >> > >>So I'm inclined to be more forgiving and leave this as it is. But maybe > >>something like a warning printk would be appropriate. > >> > > > >Ok then. > >I'll add the warning anf convert the function to be "void" rather then "int". > >Thanks! > > > > We already have a warning. > So, probably all we need is just to change a prototype to make it less confusing. > Is it ok? Sure. And/or add a comment if you think it would be useful. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
