On Thu, 21 Feb 2013 21:51:14 +0000 Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Thu, Feb 21, 2013 at 11:17:38AM -0500, Jeff Layton wrote: > > > Also, since this is the last component of the path, I suspect that > > we're almost never going to be in rcu-walk mode here, right? > > Take a look at complete_walk(); it starts with leaving RCU mode. Before > it gets anywhere near that call. Ahh good point...so that check is unnecessary with the current caller. Should we remove it and fix vfs.txt to mention that this should never be called in RCU mode, or leave it in as a defensive coding measure in case we add other callers in the future? I do sort of wonder whether we might eventually change some of the other places that call d_revalidate now to call to call this instead when LOOKUP_JUMPED is set. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
