On Wed, Feb 20, 2013 at 10:55:22AM -0500, Steve Dickson wrote: > Trimming the cc list to just Linux NFS list since I'm > sure they will not care about this part of the discussion. > I'll add them back on my next release... > > On 19/02/13 15:56, J. Bruce Fields wrote: > > On Tue, Feb 19, 2013 at 10:40:47AM -0500, Steve Dickson wrote: > >> On 19/02/13 10:18, J. Bruce Fields wrote: > >>> On Tue, Feb 19, 2013 at 10:10:15AM -0500, Steve Dickson wrote: > >>>> > >>>> > >>>> On 18/02/13 14:58, J. Bruce Fields wrote: > >>>>> On Mon, Feb 18, 2013 at 01:47:42PM -0500, Steve Dickson wrote: > >>>>>>> From: Steve Dickson <steved@xxxxxxxxxx> > >>>>>>> > >>>>>>> Here is the next release of the Label NFS patches, forward > >>>>>>> ported to linux-3.8-rc7 > >>>>>>> > >>>>>>> I believe I've incorporated all code review that were made > >>>>>>> from the last release, > >>>>> Except I think this doesn't turn on minor version 2? > >>>> Are you saying we need a -o v4.2 mount option to enable this feature? > >>> Yes. And the client needs to send requests with minor version 2, and > >>> server needs to accept such requests. > >> Boy this puts a damper on the party.... ;-) > > > > I'm hoping it's not that much work: we already have two minor versions > > (0 and 1), in theory adding a third should be pretty straightforward. > > > > Labeled NFS will be our only 4.2 feature for now, so there's nothing > > else to do other than turn on support for the new minor version number. > > > > I think so? > On the client the actual change is very straightforward. Simply added > another case to the switch in nfs_parse_version_string() and set the > minorversion to 2 > > case Opt_vers_4_2: > mnt->version = 4; > mnt->minorversion = 2; > break; > > But my question is what type of ramification well there be bumping > minorversion from 1 to 2? I bet servers are not going to like this > too much... ;-) If they support labeld NFS, they have to support minor version 2. > and not to mention all the xdr and callback routines > that look at minorversion... a bit worrisome... > > Speaking of servers... Do you think its about time to rpc.nfsd the > ability to enable 4.x versions? echo "+4.2" >/proc/fs/nfsd/versions --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
