Re: [RFC PATCH 05/13] vfs: take i_mutex on renamed file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 10, 2012 at 03:27:32PM +0800, Ram Pai wrote:

> > This seems still conform to the statement in the manual, in a weird way 
> > though.
> 
> I think the code that checks if the new dentry or the old dentry is a
> mount point can be safely removed. It does not serve any purpose AFAICT.

Yes, it does.  It's a _very_ traditional behaviour, on a lot of Unices,
and changing it can screw all kinds of scripts.  Worse yet, screw them
in rarely hit cases.

BTW, what do you expect to happen when the target is a mountpoint?  Suppose
the mountpoint is a directory that happens to be empty; you are asking to
rename another directory over it...

Anyway, userland API stability considerations are sufficient to NAK any
such change.  Sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux