2013/2/7 J. Bruce Fields <bfields@xxxxxxxxxxxx>: > On Thu, Feb 07, 2013 at 01:53:46PM +0400, Pavel Shilovsky wrote: >> Nothing prevents it. If somebody grabbed a share mode lock on a file >> before we call deny_lock_file, we simply close this file and return >> -ETXTBSY. > > But leave the newly-created file there--ugh. > >> We can't grab it before atomic_open because we don't have an >> inode there. > > If you can get the lock while still holding the directory i_mutex can't > you prevent anyone else from looking up the new file until you've gotten > the lock? > Hm..., seems you are right, I missed this part: mutex_lock lookup_open -> atomic_open -> deny_lock_file mutex_unlock that means that nobody can open and of course set flock on the newly created file (because flock is done through file descriptor). So, it should be fine to call flock after f_ops->atomic_open in atomic_open function. Thanks. -- Best regards, Pavel Shilovsky. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
