On 12/13/2012 10:20 PM, J. Bruce Fields wrote: > On Thu, Dec 13, 2012 at 09:59:08PM +0530, Suresh Jayaraman wrote: >> >> The validateascii() check in imconv() maps NFSv4 domain names with non-ASCII >> characters to 'nobody'. In setups where Active directory or LDAP is used this >> causes names with UTF-8 characters to be mapped to 'nobody' because of this >> check. >> >> As Bruce Fields puts it: >> >> "idmapd doesn't seem like the right place to enforce restrictions on names. >> Once the system has allowed a name it's too late to be complaining about it >> here." >> >> Remove the check from imconv() and remove the validateascii() function itself >> as the only user of that function is being removed by this patch. > > Thanks, seem fine. The only other thing I notice is that > validateascii() also checks (in a slightly strange way) for null > termination of the string, and it's the only place in idmapd that does. > > But I think it'd be a kernel bug to pass up a non-terminated string > here, so skipping that check is fine too. > > Possibly worth a comment, or a check just for null-termination if you > want to be extra-careful. > You are right. I think being extra-careful is Ok. I'll respin this patch with a null-termination check. Thanks -- Suresh Jayaraman -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
