On Thu, 2012-12-13 at 21:07 +0000, Al Viro wrote: > On Thu, Dec 13, 2012 at 02:45:18PM +0000, Myklebust, Trond wrote: > > > You mean aside from the fact that sb->s_remove_count remains a racy > > piece of crap that serves no good purpose for NFS, and yet will continue > > to give us grief? > > As opposed to scanning the list of opened files? For what information? sb->s_remove_count tells you nothing new about the state of the NFS filesystem. This whole "check for nlink == 0" thing is at best a heuristic, since the file may persist or disappear on the server independently of whatever we may think about the value of inode->i_nlink. Setting sirens to blare and angels to sing when we get it wrong (as we often do) is just pointless... -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com ��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥