On Wed, 12 Dec 2012 09:28:13 +1100 NeilBrown <neilb@xxxxxxx> wrote:
>
> Hi Trond et al,
> we seem to have a regression introduced by
>
> commit 7b281ee026552f10862b617a2a51acf49c829554
> NFS: fsync() must exit with an error if page writeback failed
>
> which has found it's way (in different form into -stable releases).
Bit of a clarification here. It didn't get into -stable, but we have the bug
in our 3.0 based SLES11-SP2 through a different route (I assumed it came
through stable but was being too hasty).
The bug first arrived in v3.1-rc1
commit 02c24a82187d5a628c68edfe71ae60dc135cd178
fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers
was fixed by me in v3.3-rc1
commit 2edb6bc3852c681c0d948245bd55108dc6407604
NFS - fix recent breakage to NFS error handling.
the code was then messed up a bit by
commit a5c58892b427a2752e3ec44b0aad4ce9221dc63b
NFS: Create a v4-specific fsync function
in v3.6-rc1
and that mess was fixed by
commit 7b281ee026552f10862b617a2a51acf49c829554
NFS: fsync() must exit with an error if page writeback failed
which re-introduced the original problem in v3.6-rc6.
That first patch has been backported to SLES11 so now I'm fixing the bug
again and finding it in mainline again :-)
NeilBrown
Attachment:
signature.asc
Description: PGP signature
