On 12/03/2012 09:53 AM, J. Bruce Fields wrote: > On Thu, Nov 29, 2012 at 11:40:37AM -0500, bjschuma@xxxxxxxxxx wrote: >> From: Bryan Schumaker <bjschuma@xxxxxxxxxx> >> >> While working on p2p-nfs, I discovered that I sometimes need to clear >> state for a specific client to test all possible error recovery conditions. >> The current fault injection code deletes state as it find it, so it can >> be difficult to guess which state will be forgotten. In addition, I >> currently print out the amount of state forgotten but I don't give details >> like "Forgot 3 locks from client w.x.y.z". These patches set out to >> improve that. >> >> The first 6 patches clean up the current code and prepare it for specific >> client state removal. Patch 7 adds printing information to the server's logs >> when a fault injection file is read (such as "Client w.x.y.z has 3 open >> files"). Patch 8 adds in a custom file operations structure so users can >> write strings to fault injection files in addition to u64s. Finally, patch >> 9 allows users to remove state by writing a client's IP address to one of >> the files. >> >> Changes in v4: >> - Access lock state from open owners rather than requiring a network namespace >> pointer. >> - Don't produce a null pointer expection if fault injection is attempted after >> loading the nfsd module but before running any nfsd threads. > > OK, thanks for your patience, applying this version (pending some basic > testing). Awesome, thanks! :) - Bryan > > --b. > >> >> - Bryan >> >> Bryan Schumaker (9): >> NFSD: Lock state before calling fault injection function >> NFSD: Clean up forgetting clients >> NFSD: Clean up forgetting locks >> NFSD: Clean up forgetting openowners >> NFSD: Clean up forgetting and recalling delegations >> NFSD: Fault injection operations take a per-client forget function >> NFSD: Reading a fault injection file prints a state count >> NFSD: Add a custom file operations structure for fault injection >> NFSD: Forget state for a specific client >> >> fs/nfsd/fault_inject.c | 112 ++++++++++++++++++++++++---- >> fs/nfsd/netns.h | 3 + >> fs/nfsd/nfs4state.c | 197 ++++++++++++++++++++++++++++++------------------- >> fs/nfsd/state.h | 18 +++-- >> 4 files changed, 237 insertions(+), 93 deletions(-) >> >> -- >> 1.8.0.1 >> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
