NFSd state: nfs4_lock_state() and nfs4_lock_state()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello, guys.
Right now I'm looking how client_mutex can be containerised.
And it looks like this mutex is too widely used. And I can't get what it protects exactly.

I'd like to hear your opinions about the following:
1) Why do we need to use this mutex in nfsd4_load_reboot_recovery_data()? This function is called only once on NFS server start before launching kthreads.

2) Look like using of this mutex can be easely moved out from read, write and setattr functions in nfs4proc.c to nfs4_preprocess_stateid_op() in nfs4state.c. It it also could be removed from nfs4_open(), then nfs4_lock_state() and nfs4_lock_state() can become static.

So the question is: why this mutex covers that much different code in nfsd4_open() call?

--
Best regards,
Stanislav Kinsbursky
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux