On Fri, 9 Nov 2012, J. Bruce Fields wrote: > On Fri, Nov 09, 2012 at 06:45:32PM +0000, Sven Geggus wrote: > > Sven Geggus <lists@xxxxxxxxxxxxxxxxxxxxx> wrote: > > > > > OK, I now figured out which commit did cause the problem: > > > > > > Thus "git diff 08843b79..cc8362b1" on a linux-stable tree from > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git should > > > give us the relevant changes. > > > > After a private conversation with J. Bruce Fields I figured out that > > I have not been quite there yet. So here comes a FTR post what > > exactly caused my problem. > > Thanks for tracking this down--not what I would have guessed! > > Given that the trace showed a problem starting around context creation > time, I'm most suspicious of the callers in rsc_parse, which are mostly > parsing uid's. Uh oh. Sorry about that. This might help pinpoint the problem - have simple_strto* WARN (or WARN_ONCE maybe?) just before masking out the overflow. I'm running with this now and so far I get no warnings. Cheers, Eldad diff --git a/lib/vsprintf.c b/lib/vsprintf.c index c56de78..8a748c6 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -49,6 +49,8 @@ unsigned long long simple_strtoull(const char *cp, char **endp, unsigned int bas cp = _parse_integer_fixup_radix(cp, &base); rv = _parse_integer(cp, base, &result); /* FIXME */ + WARN((rv & KSTRTOX_OVERFLOW) == KSTRTOX_OVERFLOW, + "simple_strtox overflow while parsing '%s' (base %d)\n", cp, base); cp += (rv & ~KSTRTOX_OVERFLOW); if (endp) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
