The compiler flag that enables a warning is listed in square brackets at the end of each warning message. Like: [-wsigned-comparison] Sent from my iPhone On Oct 22, 2012, at 1:27 PM, Steve Dickson <SteveD@xxxxxxxxxx> wrote: > > > On 22/10/12 12:05, Chuck Lever wrote: >> Hi- >> >> These address compiler warnings in mountd and gssd that I've found >> during recent sojourns in that code base. I've done some light >> testing, but more critical review and testing would be appreciated. >> >> I think these are appropriate for your next release of nfs-utils. > What CFLAGS do you use to see these warnings? Every time I do a build > I check for warnings and if I would have seen these I would have > fixed them immediately... > > BTW, I'm using gcc version 4.7.2 20120921 (Red Hat 4.7.2-2) (GCC) > to do my builds these days... > > steved. > >> >> --- >> >> Chuck Lever (10): >> rpc.gssd: Squelch compiler error >> rpc.gssd: Squelch compiler warning >> rpc.gssd: Squelch compiler warning >> mountd: Avoid unnecessary type conversions >> mountd: Avoid unnecessary type conversions >> mountd: Avoid unnecessary type conversions >> mountd: Make local functions static >> mountd: Eliminate unnecessary type conversions >> mountd: Avoid unnecessary type conversions >> nfs-utils: Eliminate dereferencing type punned pointers >> >> >> support/include/nfslib.h | 1 + >> support/include/sockaddr.h | 10 ++++------ >> support/nfs/cacheio.c | 5 +++++ >> utils/gssd/gss_util.c | 2 +- >> utils/gssd/gssd_proc.c | 13 +++++++------ >> utils/mountd/cache.c | 34 ++++++++++++++++++---------------- >> 6 files changed, 36 insertions(+), 29 deletions(-) >> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html