In BitKeeper, we wacked perror() to print out file, line. Saved us a ton of debugging. Oh, and bk-version as well. That helps. On Fri, Oct 12, 2012 at 07:27:08PM -0700, Boaz Harrosh wrote: > On 10/12/2012 04:52 PM, Linus Torvalds wrote: > > Guys, check this report from Larry out. > > > > Also, why the *HELL* is that a BUG_ON() in the first place? Who was > > the less-than-gifted person who decided "if this thing can happen, > > let's just kill the whole machine"? > > > > Something is trivially weird > > fs/lockd/clntxdr.c:226 is in this static function: > encode_nlm_stat() > > encode_nlm_stat() is called in two places > static void nlm_xdr_enc_res(...) > and > static void nlm_xdr_enc_testres(...) > > But these two are not called anywhere. In-fact a Kernel wide grep > returns a single occurrence of both > > I suspect the BUG_ON() belongs else where. > Perhaps we should add __func__ to the BUG_ON macro exactly for times > that source and Kernel get out of sync. > > Puzzled > Boaz -- --- Larry McVoy lm at bitmover.com http://www.bitkeeper.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
