Re: [PATCH 00/10] NFSD: Improve fault injection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 03, 2012 at 01:47:06PM -0400, Bryan Schumaker wrote:
> Bruce, have you had a chance to look at these yet?  I don't see them in your git tree...

Sorry, no, it hasn't been a high priority.

I'll try to take a look soon.  They may end up being queued up for 3.8.

--b.

> 
> - Bryan
> 
> On 09/17/2012 04:16 PM, bjschuma@xxxxxxxxxx wrote:
> > From: Bryan Schumaker <bjschuma@xxxxxxxxxx>
> > 
> > While working on p2p-nfs, I discovered that I sometimes need to clear
> > state for a specific client to test all possible error recovery conditions.
> > The current fault injection code deletes state as it find it, so it can
> > be difficult to guess which state will be forgotten.  In addition, I
> > currently print out the amount of state forgotten but I don't give details
> > like "Forgot 3 locks from client w.x.y.z".  These patches set out to
> > improve that.
> > 
> > The first 7 patches clean up the current code and prepare it for specific
> > client state removal.  Patch 8 adds prints information to the server's logs
> > when a fault injection file is read (such as "Client w.x.y.z has 3 open
> > files").  Patch 9 adds in a custom file operations structure so users can
> > write strings to fault injection files in addition to u64s.  Finally, patch
> > 10 allows users to remove state by writing a client's IP address to one of
> > the files.
> > 
> > Questions, comments and suggestions are appreciated!
> > 
> > - Bryan
> > 
> > Bryan Schumaker (10):
> >   NFSD: Fold fault_inject.h into state.h
> >   NFSD: Lock state before calling fault injection function
> >   NFSD: Clean up forgetting clients
> >   NFSD: Clean up forgetting locks
> >   NFSD: Clean up forgetting openowners
> >   NFSD: Clean up forgetting and recalling delegations
> >   NFSD: Fault injection operations take a per-client forget function
> >   NFSD: Reading a fault injection file prints a state count
> >   NFSD: Add a custom file operations structure for fault injection
> >   NFSD: Forget state for a specific client
> > 
> >  fs/nfsd/fault_inject.c | 108 ++++++++++++++++++++++++-----
> >  fs/nfsd/fault_inject.h |  28 --------
> >  fs/nfsd/nfs4state.c    | 182 +++++++++++++++++++++++++++++++------------------
> >  fs/nfsd/nfsctl.c       |   2 +-
> >  fs/nfsd/state.h        |  23 +++++++
> >  5 files changed, 230 insertions(+), 113 deletions(-)
> >  delete mode 100644 fs/nfsd/fault_inject.h
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux