Jeff Layton wrote: My only concern is this behavior described in the last patch: "If the buffered WRITE is using a credential key that will expire within low watermark seconds, fail the WRITE in nfs_write_begin _before_ the WRITE is buffered and return -EACCES to the application." Shouldn't rejecting the write attempt be the purview of the server? It seems to me that we'd be best off just switching to synchronous writes when we start approaching credential expiration, and letting the server handle the case where the credential expires. It seems to me that the client should just be in the business of recognizing when the credential might be about to expire and attempt to ensure that we don't end up with a bunch of buffered data in that case. I don't like it. It's easy to understand why writes might fail if the creds are getting stale. It's not so easy to understand why client behavior changes in a subtle way, with performance implications. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
