RE: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Missed that, co and rebuild

-----Original Message-----
From: Myklebust, Trond [mailto:Trond.Myklebust@xxxxxxxxxx]
Sent: Friday, August 17, 2012 10:46 AM
To: Shai Lazmi
Cc: William Dauchy; Schumaker, Bryan; linux-nfs@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails

On Fri, 2012-08-17 at 09:20 -0700, Shai Lazmi wrote:
> No luck ...
> ------------[ cut here ]------------
> kernel BUG at fs/nfs/idmap.c:681!

That suggests that you haven't been testing the right branch. The BUG_ON
should have been moved to line 692 after the patches were applied.

Did you copy the exact pull request from my email (i.e. "git pull
git://git.linux-nfs.org/projects/trondmy/linux-nfs.git bugfixes"? If so,
you should have gotten a vim page with a text of the form:

        Merge branch 'bugfixes' of git://git.linux-nfs.org/projects/trondmy/linux-nfs in

        # Please enter a commit message to explain why this merge is necessary,
        # especially if it merges an updated upstream into a topic branch.
        #
        # Lines starting with '#' will be ignored, and an empty message aborts
        # the commit.


(which you then follow up with a ':wq' to confirm)

A 'git log' should then show your first commit as being something along
the lines of:

        Merge: d987569 12dfd08
        Author: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
        Date:   Fri Aug 17 13:41:02 2012 -0400

            Merge branch 'bugfixes' of git://git.linux-nfs.org/projects/trondmy/linux-nf


Is that indeed the case?



--
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux