On Mon, 2012-08-13 at 23:13 +0300, Boaz Harrosh wrote:
> On 08/13/2012 12:44 PM, Peng Tao wrote:
>
> > On Mon, Aug 13, 2012 at 2:30 AM, Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote:
> >> So the small change I want is:
> >>
> >> +enum pnfs_layout_get_strategy {
> >> + PLGS_USE_ISIZE,
> >> + PLGS_SEARCH_FIRST_HOLE,
> >> + PLGS_ALL_FILE,
> >> +};
> >>
> > Just a second thought, since each layout driver would use one
> > strategy, it is more reasonable to set the strategy in
> > pnfs_curr_ld->flags instead of changing pg_init API to pass it in. I
> > will do it this way.
> >
>
>
> It's fine, as you see fit. I think it's more flexible this way but
> both ways will work for now.
>
> Please note that for files, once it will support segments, it would
> want to use i_size like objects.
Layout-specific flags in the generic code are not acceptable. If the
strategy is layout specific, then there should be no need to pass it
around the generic layers at all. Just do the right thing in the driver
(i.e. pg_init) and we're done.
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
