On Thu, 2012-07-19 at 16:46 +1000, NeilBrown wrote: > [resending - with more current address for trond] > > Hi Trond et al. > > we have a customer who reports getting the message: > [10879512.275305] NFSv4 callback: too many open connections, > consider increasing the number of threads. [10879512.275315] NFSv4 callback: > too many open connections, consider increasing the number of threads. > [10879517.276133] __ratelimit: 133011 callbacks suppressed > > Of course you cannot increase the number of threads handling callbacks. > > The patch below will get rid of the message - which is presumably mostly just > noise - or possibly change it to > NFSv4 callback: too many open connections, consider increasing the max > number of connections if the number of connections gets too high. > > This isn't much good as this patch doesn't allow the max number to be > increased. > Do we want to make the max number of callback connections configurable, or > should we find a way to silence that message. > (For lockd that message is valid as there is a sysctl to change the max > number of connections for lockd). > > Thanks, > NeilBrown > > > diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c > index 23ff18f..1129c42 100644 > --- a/fs/nfs/callback.c > +++ b/fs/nfs/callback.c > @@ -265,6 +265,10 @@ int nfs_callback_up(u32 minorversion, struct rpc_xprt > *xprt) ret = -ENOMEM; > goto out_err; > } > + /* As there is only one thread so we need to over-ride the > + * default maximum of 80 connections > + */ > + serv->sv_maxconn = 1024; > > ret = svc_bind(serv, net); > if (ret < 0) { Hi Neil, Could you please add the missing s-o-b? Cheers Trond ��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥