Re: [PATCH 05/15] NFS: Clean up TEST_STATEID and FREE_STATEID error reporting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-07-11 at 16:30 -0400, Chuck Lever wrote:
> As a finishing touch, add appropriate documenting comments and some
> debugging printk's.
> 
> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
> ---
> 
>  fs/nfs/nfs4proc.c |   32 ++++++++++++++++++++++++++++++--
>  1 files changed, 30 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index c4df35b..0d6da38 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -6636,13 +6636,28 @@ static int _nfs41_test_stateid(struct nfs_server *server, nfs4_stateid *stateid)
>  		.rpc_resp = &res,
>  	};
>  
> +	dprintk("NFS call  test_stateid %p\n", stateid);
>  	nfs41_init_sequence(&args.seq_args, &res.seq_res, 0);
>  	status = nfs4_call_sync_sequence(server->client, server, &msg, &args.seq_args, &res.seq_res, 1);
> -	if (status != NFS_OK)
> +	if (status != NFS_OK) {
> +		dprintk("NFS reply test_stateid: failed, %d\n", status);
>  		return status;
> +	}
> +	dprintk("NFS reply test_stateid: succeeded, %d\n", -res.status);
> +	return -res.status;
>  	return -res.status;

This bit didn't look cleaner, so I loped off the extra return
statement...

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com

��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux