On Thu, 12 Jul 2012 18:44:20 +0200 Karel Zak <kzak@xxxxxxxxxx> wrote: > > This patch restores the use of EX_FILEIO for errors from umount. > > Looks good to me. > > Reviewed-by: Karel Zak <kzak@xxxxxxxxxx> > > > There is a case that I know it doesn't handle. If you ask umount.nfs to > > unmount a filesystem that is not nfs or nfs4, then the old code will > > refuse > > umount.nfs: /dev/sda7 on /mnt2 is not an NFS filesystem > > > > and exit with status '1'. > > The new libmount code will just think that it couldn't find anything in > > fstab and will try to do an nfs23 unmount. This is clearly different behaviour, > > I'm not sure that anyone would care though. > > I care, it's stupid bug to use umount.nfs for non-NFS filesytems. The > patch below fixes this issue. > Cool - thanks for that! NeilBrown
Attachment:
signature.asc
Description: PGP signature
