On Jun 25, 2012, at 6:24 PM, Myklebust, Trond wrote: > On Mon, 2012-06-25 at 17:32 -0400, Chuck Lever wrote: >> On Jun 25, 2012, at 5:20 PM, Myklebust, Trond wrote: >>> Why does setting up the nfs_server depend on a successful setclientid >>> call anyway in the case of minor version 0? >> >> Should this also be the case during trunking discovery? > > I don't see how trunking discovery enters into it. The nfs_server setup > should not Oops in case of a state initialisation failure. > > However if the user sets the '-omigration' flag, then we should have > minor version 0 mount wait for trunking discovery to complete, just like > minor version 1... The problem is that in current kernels, the authentication failure in my test case occurs in nfs4_get_rootfh(). It's synchronous, in process context, and there is no state recovery activity. With trunking discovery, the first thing the client does is a SETCLIENTID. I think the answer here is not to use nfs4_handle_reclaim_lease_error() for trunking detection, since it's design appears to assume that it is running inside the state manager. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
