On 06/05/2012 04:36 PM, Adamson, Andy wrote: > > On Jun 2, 2012, at 7:00 PM, Boaz Harrosh wrote: > >> On 06/01/2012 08:19 PM, andros@xxxxxxxxxx wrote: >> >>> From: Andy Adamson <andros@xxxxxxxxxx> >>> >> >> >> I wish you would send your patches preceded with a [PATCHSET 0/x] >> That gives us a short summery and a little background on its motivation. > > I often do. These patches actually stand alone so I didn't this > time. > > This patch is totally explained by the patch title, patch comments, > and in-line comments. With out this patch, we can end up sending a > LAYOUTRETURN with no layout segments that need to be returned! Why? > because as noted in the patch comments, mark_matching_lsegs_invalid > does not indicate when the plh_segs list is empty…etc. When? well, as > noted in the in-line code comments, when the pnfs_layout_hdr has an > empty plh_segs which an occur when a LAYOUTGET fails, or when > LAYOUTGET succeeded, but the deviceid is marked invalid > Yes I noticed that the comment was very good. The in-code comment does not replace the commit title/message. I would prefer it repeated also in the patch text and/or in the cover-letter. Just to ease on the threshold to entry. > What else is there to say?! > > I guess I can add the --cover-letter to the git format-patch and > cut/paste to it. > I'm not sure what you meant. But yes exactly ;-) > -->Andy > >> Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
