On Tue, 2012-05-22 at 08:09 -0400, andros@xxxxxxxxxx wrote: > From: Andy Adamson <andros@xxxxxxxxxx> > > Signed-off-by: Andy Adamson <andros@xxxxxxxxxx> > --- > fs/nfs/write.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/fs/nfs/write.c b/fs/nfs/write.c > index e6fe3d6..c7295de 100644 > --- a/fs/nfs/write.c > +++ b/fs/nfs/write.c > @@ -1555,6 +1555,8 @@ static void nfs_commit_release_pages(struct nfs_commit_data *data) > /* We have a mismatch. Write the page again */ > dprintk(" mismatch\n"); > nfs_mark_request_dirty(req); > + nfs_unlock_request(req); > + continue; > next: > nfs_unlock_and_release_request(req); > } What is this patch trying to fix? As far as I can see it will lead to a reference leak. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com ��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥