On 5/16/12 11:44 PM, NeilBrown wrote: > On Mon, 14 May 2012 15:15:38 -0400 Steve Dickson <SteveD@xxxxxxxxxx> wrote: > >> New Features in this release: >> * The addition the nfsdcld daemon >> * The addition of the osd_login script which is mandated by the >> pnfs-objects standard > > Don't you hate it when people don't bother to test all your -rc's, then > report bugs against your final release? Me too. > > mkdir /tmp/dest > make DESTDIR=/tmp/dest install > > fails because it tries to install osd_login in /tmp/dest/sbin/osd_login > without first creating /tmp/dest/sbin. All other required directories get > created first. > > This patch - stealing an idea from utils/mount - seem to fix it. > > Thanks, > NeilBrown > > > commit 03bb227402ab023f4badb515022d49f82e01ff8d > Author: Neil Brown <neilb@xxxxxxx> > Date: Thu May 17 16:40:40 2012 +1000 > > osd_login - ensure /sbin is created before installation. > > If we use a more standard approach to describing the osd_login > script, the automake infrastructure will create /sbin before > attempting installation. > This is important for: make DESTDIR=/empty-dir install > > Signed-off-by: NeilBrown <neilb@xxxxxxx> > > diff --git a/utils/osd_login/Makefile.am b/utils/osd_login/Makefile.am > index adc493a..d17ffa7 100644 > --- a/utils/osd_login/Makefile.am > +++ b/utils/osd_login/Makefile.am > @@ -1,12 +1,9 @@ > ## Process this file with automake to produce Makefile.in > > -OSD_LOGIN_FILES= osd_login > +# These binaries go in /sbin (not /usr/sbin), and that cannot be > +# overriden at config time. > +sbindir = /sbin > > -EXTRA_DIST= $(OSD_LOGIN_FILES) > - > -all-local: $(OSD_LOGIN_FILES) > - > -install-data-hook: > - $(INSTALL) --mode 755 osd_login $(DESTDIR)/sbin/osd_login > +sbin_SCRIPTS = osd_login > > MAINTAINERCLEANFILES = Makefile.in ACK-by: Sachin Bhamare <sbhamare@xxxxxxxxxxx> Thanks for fixing this. My bad for not testing it with a non-empty DESTDIR. - sachin ----- Sachin Bhamare Panasas Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
