Re: [PATCH 2/3] NFS: O_DIRECT pgio_completion_ops error_cleanup must unlock the request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 30, 2012 at 2:05 PM, Myklebust, Trond
<Trond.Myklebust@xxxxxxxxxx> wrote:
> Alternatively, we could probably just send the write requests in an
> unlocked state. They aren't supposed to be visible to anything via any
> global lists...
>


The existing lock/commit code fairly often assumes the reqs are
locked.  I found it simpler to just lock the req than to audit all the
code paths looking for where the assumptions made a difference.

Fred
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux