Re: [PATCH 2/2] NFSv4.1: Use the correct hostname in the client identifier string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi-

On Apr 30, 2012, at 12:13 PM, Trond Myklebust wrote:

> We need to use the hostname of the process that created the nfs_client.
> That hostname is now stored in the rpc_client->cl_nodename.

This looks like exactly what I outlined in my UCS patch series, thanks.  Will you be pushing this into 3.4-rc?

> Also remove the utsname()->domainname component. There is no reason
> to include the NIS/YP domainname in a client identifier string.
> 
> Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> ---
> fs/nfs/nfs4proc.c |    5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 75eb883..99650aa 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -5122,10 +5122,9 @@ int nfs4_proc_exchange_id(struct nfs_client *clp, struct rpc_cred *cred)
> 	nfs4_construct_boot_verifier(clp, &verifier);
> 
> 	args.id_len = scnprintf(args.id, sizeof(args.id),
> -				"%s/%s.%s/%u",
> +				"%s/%s/%u",
> 				clp->cl_ipaddr,
> -				init_utsname()->nodename,
> -				init_utsname()->domainname,
> +				clp->cl_rpcclient->cl_nodename,
> 				clp->cl_rpcclient->cl_auth->au_flavor);
> 
> 	res.server_scope = kzalloc(sizeof(struct server_scope), GFP_KERNEL);
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Chuck Lever
chuck[dot]lever[at]oracle[dot]com




--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux