Re: [PATCH 1/1] mounts.nfs: v2 and v3 background mounts should retry when server is down.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi-

On Apr 25, 2012, at 11:39 AM, Steve Dickson wrote:

> The point of background mounts is to have the mount
> retried if the mount fails. This patch allows the v2/v3
> background mount to proceed in the case when the server
> is down by not making EOPNOTSUPP a permanent error.

Just curious... why wouldn't we want to do this for foreground mounts as well?

> Signed-off-by: Steve Dickson <steved@xxxxxxxxxx>
> ---
> utils/mount/stropts.c |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index d52e21a..e09aa7c 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -911,7 +911,8 @@ static int nfsmount_parent(struct nfsmount_info *mi)
> 	if (nfs_try_mount(mi))
> 		return EX_SUCCESS;
> 
> -	if (nfs_is_permanent_error(errno)) {
> +	/* retry background mounts when the server is not up */
> +	if (nfs_is_permanent_error(errno) && errno != EOPNOTSUPP) {
> 		mount_error(mi->spec, mi->node, errno);
> 		return EX_FAIL;
> 	}
> @@ -946,7 +947,8 @@ static int nfsmount_child(struct nfsmount_info *mi)
> 		if (nfs_try_mount(mi))
> 			return EX_SUCCESS;
> 
> -		if (nfs_is_permanent_error(errno))
> +		/* retry background mounts when the server is not up */
> +		if (nfs_is_permanent_error(errno) && errno != EOPNOTSUPP)
> 			break;
> 
> 		if (time(NULL) > timeout)
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Chuck Lever
chuck[dot]lever[at]oracle[dot]com




--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux