Re: [PATCH] nfs4: fix referrals on mounts that use IPv6 addrs

["Adamson, Dros" <Weston.Adamson@xxxxxxxxxx>]

On Apr 24, 2012, at 11:19 AM, Jim Rees wrote:

> Weston Andros Adamson wrote:
> 
>  diff --git a/fs/nfs/nfs4namespace.c b/fs/nfs/nfs4namespace.c
>  index 9c8eca3..307743d 100644
>  --- a/fs/nfs/nfs4namespace.c
>  +++ b/fs/nfs/nfs4namespace.c
>  @@ -52,6 +52,35 @@ Elong:
>   }
> 
>   /*
>  + * parse the path component of an nfs path ("<server>:<path>").
>  + *  nfspath - the "<server>:<path>" string
>  + *  end - pointer to end of devname component of 'nfspath'
>  + * returns NULL on failure
>  + */
> 
> The comment seems odd to me.  You're not parsing the path component, you're
> parsing the nfspath to return the path.  And the term "devname component"
> hasn't been defined anywhere.  How about this:
> 
> Return the path component of an nfs path ("<server>:<path>").

Yeah, OK.

> nfspath - the "<server>:<path>" string
> end - pointer to end of nfspath

Well, that's not really true.  "end" comes from the call to nfs_path() and points to the end of the devname component of the nfs_path, i.e.:

if "[fc00::10]:/export" is mounted:

[fc00::10]:/export/foo/bar
                  ^end

> returns NULL on failure

-dros

Attachment: smime.p7s
Description: S/MIME cryptographic signature