On Mon, 2012-04-23 at 17:47 -0400, Chuck Lever wrote: > On Apr 23, 2012, at 5:27 PM, Myklebust, Trond wrote: > > > On Mon, 2012-04-23 at 16:55 -0400, Chuck Lever wrote: > >> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c > >> index 6a1a305..df59951 100644 > >> --- a/fs/nfs/nfs4state.c > >> +++ b/fs/nfs/nfs4state.c > >> @@ -57,10 +57,12 @@ > >> #include "internal.h" > >> #include "pnfs.h" > >> > >> +#define NFSDBG_FACILITY NFSDBG_CLIENT > > > > Most of the stuff in nfs4state.c is dealing with NFSv4-specific state. > > It does not make sense to lump that in with the nfs_client debugging. > > > > It was the closest convenient. Shall I create an NFSDBG_STATE? Yes. That would be preferable... > >> + > >> #define OPENOWNER_POOL_SIZE 8 > >> > >> const nfs4_stateid zero_stateid; > >> - > >> +static DEFINE_MUTEX(nfs_clid_init_mutex); > >> static LIST_HEAD(nfs4_clientid_list); > >> > >> int nfs4_init_clientid(struct nfs_client *clp, struct rpc_cred *cred) > -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com ��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥