On Mon, Apr 16, 2012 at 5:22 PM, Myklebust, Trond
<Trond.Myklebust@xxxxxxxxxx> wrote:
> On Mon, 2012-04-09 at 16:52 -0400, Fred Isaman wrote:
>> This also has the advantage that it allows directio to use pnfs.
>>
>> Signed-off-by: Fred Isaman <iisaman@xxxxxxxxxx>
>> ---
>> -static void nfs_direct_read_release(void *calldata)
>> +static void nfs_direct_read_completion(struct nfs_pgio_header *hdr)
>> {
>> + unsigned long pos = req_offset(hdr->req);
>
> Umm... req_offset() returns an loff_t. 'unsigned long' is likely to be
> too small to hold these values on a 32-bit machine.
>
> Looking back, it looks as if the same problem exists in the page cache
> code (e.g. nfs_read_completion) as well as stuff like hdr->eof, and
> hdr->first_error.
>
>
OK, I'll fix these.
Fred
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
