Re: [osd-dev] [PATCH] pnfs-obj: Remove unused variable from objlayout_get_deviceinfo()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 31, 2012 at 12:51 AM, Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote:
> On 03/30/2012 02:29 PM, Boaz Harrosh wrote:
>
>> From: Sachin Bhamare <sbhamare@xxxxxxxxxxx>
>>
>> Local variable 'sb' was not being used in objlayout_get_deviceinfo().
>>
>> Signed-off-by: Sachin Bhamare <sbhamare@xxxxxxxxxxx>
>> Signed-off-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx>
>
>
> I was transitioning all my tree's to the 3.4-rc0 Kernel and noticed
> we forgot this patch, Please add it to what ever next-kernel branch you
> have.
>
> Benny could you please make a pnfs-all-3.3 branch? It should be identical
> to the 3.3-rc6, probably, but just for completeness.

I'll do that after rebasing to v3.3 (which I've been chasing my tail to do)

>
> Tell me if you also want to add the autologin patches to it I can help
> out with that. Else the client side went into 3.4-rc0 so I'll send you
> the exofs side for your future 3.4-rc1 tree.

I prefer to apply it for 3.4-rc.

>
> Thanks

Sure :)

Benny

> Boaz
>
>> ---
>>  fs/nfs/objlayout/objlayout.c |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/nfs/objlayout/objlayout.c b/fs/nfs/objlayout/objlayout.c
>> index 1ae53eb..b158d1b 100644
>> --- a/fs/nfs/objlayout/objlayout.c
>> +++ b/fs/nfs/objlayout/objlayout.c
>> @@ -604,7 +604,6 @@ int objlayout_get_deviceinfo(struct pnfs_layout_hdr *pnfslay,
>>  {
>>       struct objlayout_deviceinfo *odi;
>>       struct pnfs_device pd;
>> -     struct super_block *sb;
>>       struct page *page, **pages;
>>       u32 *p;
>>       int err;
>> @@ -623,7 +622,6 @@ int objlayout_get_deviceinfo(struct pnfs_layout_hdr *pnfslay,
>>       pd.pglen = PAGE_SIZE;
>>       pd.mincount = 0;
>>
>> -     sb = pnfslay->plh_inode->i_sb;
>>       err = nfs4_proc_getdeviceinfo(NFS_SERVER(pnfslay->plh_inode), &pd);
>>       dprintk("%s nfs_getdeviceinfo returned %d\n", __func__, err);
>>       if (err)
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux