Re: [PATCH 1/3] NFSv4: Fix two infinite loops in the mount code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Myklebust, Trond wrote:

  On Thu, 2012-03-29 at 08:55 +0900, Namjae Jeon wrote:
  > Hi. Trond.
  > 
  > Normally goto statement is not recommended(pipeline and branch
  > prediction) it is only recommended as a last resort if there is no
  > method to escape this loop.
  
  ????????????? A goto is an unconditional branch; there is no further
  branch prediction involved once once the processor gets the value of
  'err' in that switch statement correct. Exactly how would adding an
  extra set+test of exception.retry after the switch() help the branch
  predictor in this situation?

Besides which I see little point in optimizing this error path.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux