On Wed, Mar 28, 2012 at 07:36:01AM -0400, Jeff Layton wrote:
> If we find that "cup" is NULL in this case, then we obviously don't
> want to dereference it. What we really want to print in this case
> is the xid that we copied off earlier.
Thanks, applied.--b.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
> fs/nfsd/nfs4recover.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> index 21b53d5..eaaf948 100644
> --- a/fs/nfsd/nfs4recover.c
> +++ b/fs/nfsd/nfs4recover.c
> @@ -602,8 +602,7 @@ cld_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
>
> /* couldn't find upcall? */
> if (!cup) {
> - dprintk("%s: couldn't find upcall -- xid=%u\n", __func__,
> - cup->cu_msg.cm_xid);
> + dprintk("%s: couldn't find upcall -- xid=%u\n", __func__, xid);
> return -EINVAL;
> }
>
> --
> 1.7.7.6
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
