On Fri, 2012-03-16 at 15:32 -0400, Fred Isaman wrote:
> On Fri, Mar 16, 2012 at 2:43 PM, Trond Myklebust
> <Trond.Myklebust@xxxxxxxxxx> wrote:
> > Move more pnfs-isms out of the generic commit code.
> > -out_put:
> > - put_lseg(lseg);
> > + if (rv != 0)
> > + set_bit(NFS_INO_PNFS_COMMIT, &NFS_I(inode)->flags);
>
> A quibble...I would put the set_bit up a layer, in the actual
> pnfs_scan_commit_lists function.
> Other than that, both patches look good to me.
>
Moving it into pnfs_scan_commit_lists sounds fair...
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
