On Fri, 2012-03-16 at 13:42 -0400, Daniel Kahn Gillmor wrote: > On 03/16/2012 01:36 PM, Myklebust, Trond wrote: > > The problem is that if the client doesn't have a machine cred, then you > > end up taking a random user credential that may not currently be holding > > any OPEN files. In that case too the RENEW will fail. > > So if i'm understanding this right: > > Sachin's proposal fails when the machine has no machine creds. > > The current implementation fails when the logged-in user's credentials > are expired. > > Can the NFS client's logic test for those different cases, use the > appropriate creds for RENEW in their difference, and reduce the failure > case to their intersection? Simpler solution: add the call to get machine creds to the existing get_renew_creds function. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com ��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥