RE: [PATCH 1/1] nfsd: Warn when no servers are specified on the command line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I am curious why such a message is required?  Isn't the reason for having a default is so that the option does not need to specified?

	Thanx...

		ps


-----Original Message-----
From: linux-nfs-owner@xxxxxxxxxxxxxxx [mailto:linux-nfs-owner@xxxxxxxxxxxxxxx] On Behalf Of Steve Dickson
Sent: Thursday, March 15, 2012 1:24 PM
To: Linux NFS Mailing list
Subject: [PATCH 1/1] nfsd: Warn when no servers are specified on the command line

When the number of servers are not specified on the command, log a warning message that the default number of services will be started

Signed-off-by: Steve Dickson <steved@xxxxxxxxxx>
---
 utils/nfsd/nfsd.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c index 8bc5d3a..c744ee1 100644
--- a/utils/nfsd/nfsd.c
+++ b/utils/nfsd/nfsd.c
@@ -188,6 +188,8 @@ main(int argc, char **argv)
 		}
 	}
 
+	xlog_open(progname);
+
 	if (optind < argc) {
 		if ((count = atoi(argv[optind])) < 0) {
 			/* insane # of servers */
@@ -203,10 +205,11 @@ main(int argc, char **argv)
 			socket_up = 1;
 			goto set_threads;
 		}
+	} else {
+		xlog(L_WARNING, "No server number specified. '%d' nfsd will be started",
+			count);
 	}
 
-	xlog_open(progname);
-
 	nfsd_enable_protos(&proto4, &proto6);
 
 	if (!NFSCTL_TCPISSET(protobits)) {
--
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux