Re: [PATCH 1/1] NFS4: remove erroneous BUG_ONs in file layout pg_init functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-03-13 at 15:19 -0400, Fred Isaman wrote:
> These BUG_ONs assume that pg_init is called once per nfs_pageio_descriptor,
> yet it is actually called once per attempted RPC call.

Shouldn't the pg_lseg _always_ get cleared out in the pg_doio callback?
If not, we risk leaking lsegs.
IOW: As far as I can tell, those BUG_ONs are correct.

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com

��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥



[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux