On Fri, Mar 9, 2012 at 2:51 PM, Myklebust, Trond <Trond.Myklebust@xxxxxxxxxx> wrote: > On Fri, 2012-03-09 at 14:31 -0800, Fred Isaman wrote: >> On Thu, Mar 8, 2012 at 8:03 AM, <andros@xxxxxxxxxx> wrote: >> > From: Andy Adamson <andros@xxxxxxxxxx> >> > >> > The error handler nfs4_state parameter is never NULL in the pNFS case as >> > the open_context must carry an nfs_state. >> > >> >> >> Note Trond's argument is that with commit the state is avail for the >> caller, so it need not be NULL. >> But the caller filelayout_commit_done_cb() needs to be adjusted. >> Currently commit to ds oopses >> due to that. > > Are you sure? As far as I can see, filelayout_commit_pagelist _does_ > call nfs_init_commit(), which again sets the data->args.context. > Later, filelayout_commit_done_cb calls filelayout_async_handle_error() > using the data->args.context->state argument. > > How is that failing to provide a valid open state argument? > > -- Gah, sorry. A rebase of some of my commit changes silently reverted it to a NULL argument. I withdraw my complaint. Fred -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
