Re: [PATCH 1/3] NFSv4.1: Fix the checking of the stateid when returning a delegation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 06, 2012 at 03:13:37PM +0000, Adamson, Andy wrote:
> 
> On Mar 6, 2012, at 9:57 AM, Myklebust, Trond wrote:
> 
> > On Tue, 2012-03-06 at 09:46 -0500, andros@xxxxxxxxxx wrote:
> >> From: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> >> 
> >> nfs41_validate_delegation_stateid is broken if we supply a stateid with
> >> a non-zero sequence id. Instead of trying to match the sequence id,
> >> the function assumes that we always want to error. While this is
> >> true for a delegation callback, it is not true in general.
> >> 
> >> Also fix a typo in nfs4_callback_recall.
> >> 
> >> Reported-by: Andy Adamson <andros@xxxxxxxxxx>
> >> Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> > 
> > Did you really intend to Cc: stable on these before we've committed them
> > upstream?
> 
> I guess I misunderstood when to add the Cc: stable.

Me too--I thought the stable folks would wait till they see a commit?

Though adding a Cc: line with the Signed-off-by's and leaving them out
of the email header would seem simpler.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux