Trond-
Can you please reverse these checks in your version of the commit?
Begin forwarded message:
> From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Subject: re: NFS: Add a client-side function to display NFS file handles
> Date: March 6, 2012 5:51:35 AM EST
> To: chuck.lever@xxxxxxxxxx
> Cc: linux-nfs@xxxxxxxxxxxxxxx
>
> Hello Chuck Lever,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 20d27e929fb4: "NFS: Add a client-side function to display
> NFS file handles" from Mar 1, 2012, leads to the following Smatch
> complaint:
>
> fs/nfs/inode.c:1061 _nfs_display_fhandle()
> warn: variable dereferenced before check 'fh' (see line 1061)
>
> fs/nfs/inode.c
> 1060
> 1061 if (fh->size == 0 || fh == NULL) {
> ^^^^^^^^ ^^^^^^^^^^
> dereference check
>
> 1062 printk(KERN_DEFAULT "%s at %p is empty\n", caption, fh);
> 1063 return;
>
> regards,
> dan carpenter
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
