On Tue, Mar 06, 2012 at 10:59:55AM +0100, Bernd Schubert wrote: > Arg, my bad, I introduced this issue when I converted from f_flags > to f_mode, seems I forgot all of those above :( > Hrm, I thought I had tested sufficiently, but obviously I did not :( > Here's the test tool. > http://www.pci.uni-heidelberg.de/tc/usr/bernd/downloads/test_seekdir/ > > While quickly looking, I think it only affects NFSv2, which I think > I indeed didn't test. I only run tests for 32 bit and 64-bit user > space and NFSv3. But yes, NFSv2 is an important test too. Not sure > if I will find time for that today. I think the problem case to worry about would have been on a 32-bit NFS server (think embedded/bookshelf NAS servers) and NFSv3, since that's where the inconsistency would have meant that hash2pos would use the 32-bit codepath, but pos2maj_hash would use the 64-bit codepath, and so then... kablooey. > Will send an updated version later on. If it's just those changes, no worries, as I've already fixed up the f_flags vs. f_mode issue in my copy of the patches. Let me know if there are any other changes that you'd like to make or issues that you've spotted. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
