Hi Dros, On 02/17/2012 03:20 PM, Weston Andros Adamson wrote: > Shows the implementation ids in /proc/self/mountstats. This doesn't break > the nfs-utils mountstats tool. > > Signed-off-by: Weston Andros Adamson <dros@xxxxxxxxxx> > --- > fs/nfs/client.c | 1 + > fs/nfs/nfs4proc.c | 21 +++++++++++++++++++++ > fs/nfs/nfs4xdr.c | 42 +++++++++++++++++++++++++++++++++++++----- > fs/nfs/super.c | 8 ++++++++ > include/linux/nfs_fs_sb.h | 2 ++ > include/linux/nfs_xdr.h | 15 +++++++-------- > 6 files changed, 76 insertions(+), 13 deletions(-) > <snip> > diff --git a/fs/nfs/super.c b/fs/nfs/super.c > index d05024a..5462225 100644 > --- a/fs/nfs/super.c > +++ b/fs/nfs/super.c > @@ -809,6 +809,14 @@ static int nfs_show_stats(struct seq_file *m, struct dentry *root) > > seq_printf(m, "\n\tage:\t%lu", (jiffies - nfss->mount_time) / HZ); > > + if (nfss->nfs_client && nfss->nfs_client->impl_id) { > + struct nfs41_impl_id *impl_id = nfss->nfs_client->impl_id; "struct nfs41_impl_id" is only defined when CONFIG_NFS_V4_1 is enabled, so if I compile without NFS 4.1 enabled I get this error: CC [M] fs/nfs/super.o /home/bjschuma/linux/modules/fs/nfs/super.c: In function 'nfs_show_stats': /home/bjschuma/linux/modules/fs/nfs/super.c:843:14: error: dereferencing pointer to incomplete type /home/bjschuma/linux/modules/fs/nfs/super.c:843:29: error: dereferencing pointer to incomplete type /home/bjschuma/linux/modules/fs/nfs/super.c:844:14: error: dereferencing pointer to incomplete type /home/bjschuma/linux/modules/fs/nfs/super.c:844:37: error: dereferencing pointer to incomplete type make[3]: *** [fs/nfs/super.o] Error 1 - Bryan > + seq_printf(m, "\n\timpl_id:\tname='%s',domain='%s'," > + "date='%llu,%u'", > + impl_id->name, impl_id->domain, > + impl_id->date.seconds, impl_id->date.nseconds); > + } > + > seq_printf(m, "\n\tcaps:\t"); > seq_printf(m, "caps=0x%x", nfss->caps); > seq_printf(m, ",wtmult=%u", nfss->wtmult); -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html