On Thu, 2012-03-01 at 22:35 +0000, Myklebust, Trond wrote:
> On Thu, 2012-03-01 at 17:02 -0500, Chuck Lever wrote:
> > Clean up due to code review.
>
> > -typedef struct { char data[NFS4_VERIFIER_SIZE]; } nfs4_verifier;
> > +typedef union {
> > + unsigned char data[NFS4_VERIFIER_SIZE];
> > + u32 data32[NFS4_VERIFIER_SIZE / sizeof(u32)];
>
> The above should really be a __be32 type. We don't ever convert
> verifiers.
Correction.... As I said for 15/15, these things are documented in the
spec as being opaque. The fact that we don't always treat them that way
doesn't justify the above change.
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
��.n��������+%������w��{.n�����{��w��� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
